On Mon, Aug 13, 2018 at 6:55 PM Junio C Hamano <gits...@pobox.com> wrote: > > Duy Nguyen <pclo...@gmail.com> writes: > > > I was careless and checked the wrong variable (should have checked > > nr_duplicates not state.nr_duplicates; the second is a pointer). So we > > always get this warning (and with no following list of files) > > Heh, does that bug go away if you got rid of the pointer-ness of the > field and store the value directly in there?
You mean replacing the pointer with a real counter in struct checkout? That would not work (it was my first option) because struct checkout is passed around as a const struct. entry.c code is not allowed to make any updates there. So I got rid of both "nr_duplicates" and just count again at the bottom of check_updates(). It's not that expensive and it simplifies the code. -- Duy
