On Sat, Oct 21, 2017 at 01:50:01AM +0200, SZEDER Gábor wrote: > > On Thu, Oct 19, 2017 at 05:01:40PM -0400, Jeff King wrote: > > > > > I sometimes run git's test suite as part of an automated testing > > > process. I was hoping to add "-x" support to get more details when a > > > test fails (since failures are sometimes hard to reproduce). > > Would it make sense (or be feasible) to enable "-x" on Travis CI?
Yes, after this series I think it may be workable to do so. > > @@ -2350,6 +2357,7 @@ GIT-LDFLAGS: FORCE > > # and the first level quoting from the shell that runs "echo". > > GIT-BUILD-OPTIONS: FORCE > > @echo SHELL_PATH=\''$(subst ','\'',$(SHELL_PATH_SQ))'\' >$@+ > > + @echo TEST_SHELL_PATH=\''$(subst ','\'',$(TEST_SHELL_PATH_SQ))'\' >$@+ > > This redirection overwrites, loosing the just written SHELL_PATH. It > should append like the lines below. Doh, thank you. It's interesting that nothing broke with this error. But I think when run via Make that we end up with SHELL_PATH via the environment (set to the default /bin/sh, which was suitable for my system). I'll fix it. -Peff
