Ben Peart <benpe...@microsoft.com> writes:
> The only behavioral change from V7 is the removal of unnecessary uses of
> CE_MATCH_IGNORE_FSMONITOR. With a better understanding of *why* the
> CE_MATCH_IGNORE_* flags are used, it is now clear they are not required
> in most cases where CE_MATCH_IGNORE_FSMONITOR was being passed out of an
> abundance of caution.
The reviews and updates after this round was posted were to
* 01/12 had an obvious pointer-vs-pointee thinko, which I think I
have locally fixed;
* 08/12 forgot to add a new test executable to .gitignore file,
which I think I have locally fixed, too.
Any other review comments and suggestions for improvements?
Otherwise I am tempted to declare victory and merge this to 'next'
soonish.
For reference, here is the interdiff between what was posted as v8
and what I have on 'pu'.
Thanks.
compat/bswap.h | 4 ++--
t/helper/.gitignore | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git b/compat/bswap.h a/compat/bswap.h
index 6b22c46214..5078ce5ecc 100644
--- b/compat/bswap.h
+++ a/compat/bswap.h
@@ -183,8 +183,8 @@ static inline uint32_t get_be32(const void *ptr)
static inline uint64_t get_be64(const void *ptr)
{
const unsigned char *p = ptr;
- return (uint64_t)get_be32(p[0]) << 32 |
- (uint64_t)get_be32(p[4]) << 0;
+ return (uint64_t)get_be32(&p[0]) << 32 |
+ (uint64_t)get_be32(&p[4]) << 0;
}
static inline void put_be32(void *ptr, uint32_t value)
diff --git b/t/helper/.gitignore a/t/helper/.gitignore
index f9328eebdd..87a648a7cf 100644
--- b/t/helper/.gitignore
+++ a/t/helper/.gitignore
@@ -5,6 +5,7 @@
/test-delta
/test-drop-caches
/test-dump-cache-tree
+/test-dump-fsmonitor
/test-dump-split-index
/test-dump-untracked-cache
/test-fake-ssh
