> -----Original Message----- > From: Martin Ågren [mailto:martin.ag...@gmail.com] > Sent: Friday, September 22, 2017 7:37 PM > To: Ben Peart <ben.pe...@microsoft.com> > Cc: David Turner <david.tur...@twosigma.com>; Ævar Arnfjörð Bjarmason > <ava...@gmail.com>; Christian Couder <christian.cou...@gmail.com>; > git@vger.kernel.org; Junio C Hamano <gits...@pobox.com>; Johannes > Schindelin <johannes.schinde...@gmx.de>; Nguyễn Thái Ngọc Duy > <pclo...@gmail.com>; Jeff King <p...@peff.net> > Subject: Re: [PATCH v8 08/12] fsmonitor: add a test tool to dump the index > extension > > On 22 September 2017 at 18:35, Ben Peart <benpe...@microsoft.com> > wrote: > > Add a test utility (test-dump-fsmonitor) that will dump the fsmonitor > > index extension. > > > > Signed-off-by: Ben Peart <benpe...@microsoft.com> > > --- > > Makefile | 1 + > > t/helper/test-dump-fsmonitor.c | 21 +++++++++++++++++++++ > > 2 files changed, 22 insertions(+) > > create mode 100644 t/helper/test-dump-fsmonitor.c > > You forget to add the new binary to .gitignore. (In patch 12/12, you introduce > test-drop-caches, which you _do_ add to .gitignore.) >
Oops. Thanks! Hopefully Junio can squash this in... > Martin > > diff --git a/t/helper/.gitignore b/t/helper/.gitignore index > 6f07de62d..0fe2e0440 100644 > --- a/t/helper/.gitignore > +++ b/t/helper/.gitignore > @@ -6,6 +6,7 @@ > /test-delta > /test-drop-caches > /test-dump-cache-tree > +/test-dump-fsmonitor > /test-dump-split-index > /test-dump-untracked-cache > /test-fake-ssh > -- > 2.14.1.727.g9ddaf86
