Jean-Noël Avila <jn.av...@free.fr> writes:

> Le 20/07/2017 à 20:57, Junio C Hamano a écrit :
>>
>> +    git diff --quiet HEAD && git diff --quiet --cached
>> +
>> +    @for s in $(LOCALIZED_C) $(LOCALIZED_SH) $(LOCALIZED_PERL); \
>
> Does PRIuMAX make sense for perl and sh files?

Not really; I did this primarily because I would prefer to keep
things consistent, anticipating there may be some other things we
need to replace before running gettext(1) for other reasons later.

I do not mind removing them, if Jiang/Dscho already reviewed and
tested _this_ version (which we do not yet know), I'd prefer not to
touch it for the upcoming release.

Thanks for reading it over.


>> +    do \
>> +            sed -e 's|PRItime|PRIuMAX|g' <"$$s" >"$$s+" && \
>> +            cat "$$s+" >"$$s" && rm "$$s+"; \
>> +    done
>> +
>>      $(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ $(XGETTEXT_FLAGS_C) $(LOCALIZED_C)
>>      $(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ --join-existing $(XGETTEXT_FLAGS_SH) 
>> \
>>              $(LOCALIZED_SH)
>>      $(QUIET_XGETTEXT)$(XGETTEXT) -o$@+ --join-existing 
>> $(XGETTEXT_FLAGS_PERL) \
>>              $(LOCALIZED_PERL)
>> +
>> +    git reset --hard
>>      mv $@+ $@
>>  
>>  .PHONY: pot

Reply via email to