On Fri, May 12, 2017 at 07:23:04PM -0600, Alex Henrie wrote: > When I saw Brian's email today, my first thought was "What was I > thinking?" My mistake was pretty obvious. Then I remembered that when > I wrote the original patch, I wasn't sure where to set the default > value, because there were no clear examples in this file. Now that > we've established a clear precedent for setting the log.decorate > default (and other defaults like it) in init_log_defaults, I don't > expect any more problems with log.decorate. And since it's not > practical to add tests for similar bugs for every command and > configuration option in Git, we'll just have to be a little more > vigilant about code review. > > Again, I apologize for the trouble.
Everyone sends a patch that breaks sometimes (I've broken kernel.org's infrastructure). We try hard to avoid it, but we don't always succeed. I appreciate your review on my patch and suggestion on how to improve it, and I hope this won't put you off from further contributions. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
