On Fri, May 12, 2017 at 04:48:14PM -0700, Jonathan Nieder wrote: > Hi, > > brian m. carlson wrote: > > > Does anyone else have views on whether this is good thing to test for? > > I know you don't mean to be rude, but this comes across as a bit of > a dismissive question.
Sorry, that wasn't my intention, but I see how it could have come off that way. I was trying to solicit other opinions, but did a bad job and implied yours wasn't valuable. I apologize. > > On Fri, May 12, 2017 at 04:32:14PM -0700, Jonathan Nieder wrote: > > In my humble opinion, the bug being subtle makes it especially useful > to have a test that describes that bug. That way, if someone is > refactoring this code later then they know what to watch out for not > reintroducing. Okay. I'll reroll with a patch to the tests. I agree that this is rather subtle. -- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
signature.asc
Description: PGP signature
