Hi Stefan, On Tue, 25 Apr 2017, Stefan Beller wrote:
> On Tue, Apr 25, 2017 at 2:51 PM, Jonathan Tan <jonathanta...@google.com> > wrote: > > On 04/25/2017 02:04 PM, Stefan Beller wrote: > >> > >> Thanks for the fix. :) > >> Do we want to test for this use case in the future? > > > > > > Thanks! > > > > I'm not sure of the value of including a test for this specific use case, > > because Git normally does not create commit messages with no trailing > > newlines. (To test this, I suspect I would need to use hash-object with a > > specifically crafted commit object.) > > Okay, makes sense to omit a test. > In that case: Is it needed to hint at how this bug occurred in the wild? > (A different Git implementation, which may be fixed now?) Just because Git usually does not create commit messages without trailing newlines does not mean that it is a rare thing. We got bug reports about this, so I think it is frequent enough that we could save time by adding that test and avoid future bug reports/bug hunts. Ciao, Johannes
