Siddharth Kannan <kannan.siddhart...@gmail.com> writes:
> On 17 February 2017 at 00:38, Junio C Hamano <gits...@pobox.com> wrote:
>> Having said all that, I do not think the remainder of the code is
>> prepared to take "-", not yet anyway [*1*], so turning "-" into
>> "@{-1}" this patch does before it calls get_sha1_basic(), while it
>> is not an ideal final state, is probably an acceptable milestone to
>> stop at.
>
> So, is it okay to stop with just supporting "-" and not support things
> like "-@{yesterday}"?
If the approach to turn "-" into "@{-1}" at that spot you did will
cause "-@{yesterday}" to barf, then I'd say so be it for now ;-).
We can later spread the understanding of "-" to functions deeper in
the callchain and add support for that, no?
>> It is a separate matter if this patch is sufficient to produce
>> correct results, though. I haven't studied the callers of this
>> change to make sure yet, and may find bugs in this approach later.
