Michael Haggerty <mhag...@alum.mit.edu> writes: > Push the submodule attribute down from ref_store to files_ref_store. > This is another step towards loosening the 1:1 connection between > ref_stores and submodules.
The update seems to retain the externally visible effects, but what does this change mean for future backend writers whose code will sit next to files_ref_store? They need to have "submodule" field in their implementation of the backend and keep track of it? Granted that the primary thing that looks at ->submodule field in the code before this change all live in refs/files-backend.c, but I am not sure if that is an artifact of us having only one backend at this moment, or a sign that future backends would benefit from extra freedom to choose how they exactly implement their submodule support.
