Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email )
Change subject: V1.2: Change fields in ProvideEimPackage(Result) ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/ipa/libipa/esipa_prvde_eim_pkg_rslt.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/comment/582d45c9_c65bba65?usp=email : PS6, Line 86: res->eim_acknowledgements = &msg_to_ipa->choice.provideEimPackageResultResponse.choice.eimAcknowledgements; I wonder if we should be more explcit in the case of an emptyResponse. We could have a bool empty_response in the result and set that to true in case ProvideEimPackageResultResponse_PR_emptyResponse is present. Then the caller has a more exact result. We also do not return the provideEimPackageResultError field yet. Maybe we should do that. (sure, the caller can always look into msg_to_ipa but that pointer servers more as an input for the free functions. The philosophy is to bring the interesting IEs directly to the front in the response structure.) -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43055?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I24baab4f9351aec27c58403b94974cba4b274c34 Gerrit-Change-Number: 43055 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Wed, 19 Aug 2026 12:21:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
