Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email )

Change subject: ranap_msg_factory: Fix API documentation regarding ip param 
endianness
......................................................................


Patch Set 1:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/c14f0955_6cbdd037?usp=email
 :
PS1, Line 20: an
> missing space
Done


File src/ranap_msg_factory.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/a421604e_9528d09e?usp=email
 :
PS1, Line 794:  * \param rtp_ip  MGW's RTP IPv4 address in *network* byte order.
> you may add a comment about the rtp_port as well.
I'll better improve the doc on the next patch where I'm adding the new API.


https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bdf0275c_53d4cc4f?usp=email
 :
PS1, Line 870:                                     uint32_t gtp_tei, bool 
use_x213_nsap)
> same as for rtp_port: optional: tei is also in host byte order
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2
Gerrit-Change-Number: 43257
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Tue, 18 Aug 2026 09:27:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <[email protected]>

Reply via email to