Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by pespin. ( 
https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email )

Change subject: ranap_msg_factory: Fix API documentation regarding ip param 
endianness
......................................................................


Patch Set 1: Code-Review+1

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/84db183d_177d7ae1?usp=email
 :
PS1, Line 20: an
missing space


File src/ranap_msg_factory.c:

https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bedf84d0_7d5bb27e?usp=email
 :
PS1, Line 794:  * \param rtp_ip  MGW's RTP IPv4 address in *network* byte order.
you may add a comment about the rtp_port as well.


https://gerrit.osmocom.org/c/osmo-iuh/+/43257/comment/bb74ba7f_0051a45c?usp=email
 :
PS1, Line 870:                                     uint32_t gtp_tei, bool 
use_x213_nsap)
same as for rtp_port: optional: tei is also in host byte order



--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/43257?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I0a909019875714d35c27aa38dd5520a82d46e8f2
Gerrit-Change-Number: 43257
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 18 Aug 2026 09:24:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to