Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43044?usp=email )
Change subject: V1.2: Add function ES10b.DisableEmergencyProfile ...................................................................... Patch Set 6: Code-Review+2 (2 comments) File include/onomondo/ipa/ipad.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/1973b96b_18437526?usp=email : PS3, Line 100: int ipa_disable_emergency_profile(struct ipa_context *ctx); > maybe shorten "profile" to "prfle" and "emergency" to "emerg"? Done File src/ipa/libipa/es10b_dis_emerg_prfle.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/9c6b2462_c48ddd9b?usp=email : PS3, Line 14: struct DisableEmergencyProfileResponse *res; > Also here, maybe just return the integer result? Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I2af2077228fb8c5fa3f254acc15bd0afaa33fe43 Gerrit-Change-Number: 43044 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 14:06:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: dexter <[email protected]>
