Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43044?usp=email )
Change subject: V1.2: Add function ES10b.DisableEmergencyProfile ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File include/onomondo/ipa/ipad.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/152d9447_f5c1ce33?usp=email : PS3, Line 100: int ipa_disable_emergency_profile(struct ipa_context *ctx); maybe shorten "profile" to "prfle" and "emergency" to "emerg"? File src/ipa/libipa/es10b_dis_emerg_prfle.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/ee9fba39_2eeedfbf?usp=email : PS3, Line 14: struct DisableEmergencyProfileResponse *res; Also here, maybe just return the integer result? File src/ipa/main.c: https://gerrit.osmocom.org/c/onomondo-ipa/+/43044/comment/3c407d0d_264c228f?usp=email : PS3, Line 56: printf(" --disable-emergency-profile. Trigger return from emergency profile to previous profile\n"); > see my comment on an earlier patch of this series about options that are […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43044?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I2af2077228fb8c5fa3f254acc15bd0afaa33fe43 Gerrit-Change-Number: 43044 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2026 15:58:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]>
