Attention is currently required from: jolly. dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )
Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/ipa/libipa/es10b_exec_fallback_mech.h: https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/17d88bd5_baec11e4?usp=email : PS3, Line 14: struct ExecuteFallbackMechanismResponse *res; The response is basically just an integer, you could return that integer from ipa_es10b_exec_fallback_mech directly. This would allow you to get rid of ipa_es10b_exec_fallback_mech_res_free and the API would me much simpler. However, the downside is that there would be less flexibility in case the response struct gets extended. -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc Gerrit-Change-Number: 43041 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: jolly <[email protected]> Gerrit-Comment-Date: Fri, 07 Aug 2026 15:24:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
