Attention is currently required from: dexter.

jolly has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email )

Change subject: V1.2: Add function ES10b.ExecuteFallbackMechanism
......................................................................


Patch Set 2:

(3 comments)

File src/ipa/libipa/ipad.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/5b0300b1_bc3ef106?usp=email
 :
PS1, Line 282:  exec_fallback_mech.req.refreshFlag = refresh_flag;
> You could put the whole setup into ipa_es10b_exec_fallback_mech and call the 
> function like this: […]
Done


File src/ipa/main.c:

https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/0b34b0bc_c000879b?usp=email
 :
PS1, Line 53:   printf(" --refresh-flag.............. Make eUICC send a CAT 
refresh after switchting profile with the triggers above.\n");
> I think we should use the refresh_flag from (cfg.refresh_flag, see ipad.h). 
> […]
Done


https://gerrit.osmocom.org/c/onomondo-ipa/+/43041/comment/61c741d3_254c843d?usp=email
 :
PS1, Line 209:                  getopt_refresh_flag = true;
> maybe set […]
Done



--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43041?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: Ia751f0888c36f39ddfadf7f8bb923a8ee50178dc
Gerrit-Change-Number: 43041
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jul 2026 09:23:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to