Attention is currently required from: jolly, pespin.

laforge has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email )

Change subject: Add VTY test for "listen" node of osmo-stp VTY config
......................................................................


Patch Set 4:

(3 comments)

File tests/vty/osmo_stp_test.vty:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/c7ac542e_69ece7f5?usp=email
 :
PS2, Line 393: help
             :   list [with-flags]
             :   show vty-attributes
             :   show vty-attributes (application|library|global)
             :   write terminal
             :   write file [PATH]
             :   write memory
             :   write
             :   show running-config
             :   exit
             :   end
> see  below
Done


https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/bf078c99_1252516c?usp=email
 :
PS2, Line 415:  help                    Description of the interactive help 
system
             :   list                    Print command list
             :   show                    Show running system information
             :   write                   Write running configuration to memory, 
network, or terminal
             :   exit                    Exit current mode and down to previous 
mode
             :   end                     End current mode and change to enable 
mode.
> those commands do not originate in libosmo-sigtran, do they? If libosmocore 
> were to change the help  […]
Done


https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/c407ecb9_c1482807?usp=email
 :
PS2, Line 431:   init-ip-dscp  Specify IP DSCP of Listener
> like here...
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia1ceb5f0374f47ff269b557be30fc4d59550d1a6
Gerrit-Change-Number: 42817
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 05 Aug 2026 18:05:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to