Attention is currently required from: jolly.

pespin has posted comments on this change by jolly. ( 
https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email )

Change subject: Add VTY test for "listen" node of osmo-stp VTY config
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

File tests/vty/osmo_stp_test.vty:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817/comment/9ba39bf6_02992d85?usp=email
 :
PS1, Line 405:   local-ip (A.B.C.D|X:X::X:X)
AFAIU you should only be explicitly expecting the commands added by 
libosmo-sgitran here, ie. remove the lines above (leave the "...").
Otherwise if libosmocore changes this tests will start failing.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42817?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia1ceb5f0374f47ff269b557be30fc4d59550d1a6
Gerrit-Change-Number: 42817
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Thu, 04 Jun 2026 20:06:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to