Attention is currently required from: fixeria, laforge. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email )
Change subject: personalization: fix EF_SMSP length, alpha_id padding ...................................................................... Patch Set 5: Verified+1 (3 comments) Patchset: PS5: I have tested this patch with a small test program and TS48V1-B-UNIQUE.der. When I parse the results with saip_tool.py the encoded result looks fine. I get the expected amount of padding at the beginning. With that I see no major problems with this patch. We could just polish the last bits (no need to set alpha ID, rec length 38 instead of 42) and then merge it. PS5: > One still has to ensure to pass the file length (total_len=f_smsp.rec_len) to > encode_record_hex. […] Done File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42674/comment/f46d9e41_846e730c?usp=email : PS5, Line 638: f_smsp.rec_len = 42 > (missing detail: the current version also does NOT set `f_smsp. […] The size of 38 is the default that TCA suggests. If it works with 38, then this probably means that efFileSize is not set in the template. In any case, using a size of 38 sounds reasonable. This would leave 10 chars for the alpha id. I think that 10 chars "ought to be enough for anybody". If this is the only problem we could just set f_smsp.rec_len to 38. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 01 Jun 2026 10:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: dexter <[email protected]>
