Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42674?usp=email )
Change subject: personalization: fix EF_SMSP length, alpha_id padding ...................................................................... Patch Set 5: Code-Review+1 (4 comments) Patchset: PS5: As far as I can see this patch is almost ready for merging. Since we do not need to set the alpha id here anymore I would recommend to re-align the patch a bit. Otherwise everything should be fine. PS5: > I think this might possibly no longer be needed with https://gerrit.osmocom. > […] One still has to ensure to pass the file length (total_len=f_smsp.rec_len) to encode_record_hex. So this patch is still relevant. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42674/comment/95fb4454_44ae9b00?usp=email : PS5, Line 637: ef_smsp_dec['alpha_id'] = '' With (I0ec99b2648b22c56f9145345e4cd8776f9217701, already merged), setting the alpha id is optional. You could remove this line and it would still work. https://gerrit.osmocom.org/c/pysim/+/42674/comment/50a07c90_d3a63b55?usp=email : PS5, Line 638: f_smsp.rec_len = 42 Keep in mind that this hardcoded value (42) must be consistent with the file length assigned in the PE. But as far as I remember we already discussed that and found that the generator would ensure the consistency. I just wanted to remind you to be sure. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ief6e02517f3e96158a2509d763b88aec4bd5a296 Gerrit-Change-Number: 42674 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 11 May 2026 09:12:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]>
