Attention is currently required from: pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email )
Change subject: tests: improve test infrastructure to support multiple test vectors ...................................................................... Patch Set 2: (3 comments) File tests/parse/tcap_parse_test.c: https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/fac260d0_17a24d3c?usp=email : PS2, Line 18: #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > we have an OSMO_ define for this already in libosmocore. […] No, it doesn't depend on any other libraries, not even libosmocore https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/43327a83_72b903cb?usp=email : PS2, Line 30: static const unsigned char pkt_begin[] = {0x62, 0x06, 0x48, 0x04, 0x00, 0x01, 0x02, 0x03}; > Can you please put in the file as a comment the decoded tree by wireshark? Acknowledged https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/41dfdbaa_7a179108?usp=email : PS2, Line 55: printf("Broken encoding %u at byte %lu\n", rc.code, rc.consumed); > broken decoding? Acknowledged -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I4a69167647dd0a8eb650b4c7cc47fd97928ebf5d Gerrit-Change-Number: 42743 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 14 May 2026 06:44:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
