Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email )

Change subject: tests: improve test infrastructure to support multiple test 
vectors
......................................................................


Patch Set 2:

(2 comments)

File tests/parse/tcap_parse_test.c:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/11f84b10_4578cc43?usp=email
 :
PS2, Line 51:           printf("Decoding testvector no %i - %s\n", i, 
testvectors[i].name);
Use %d instead of %i


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743/comment/04d0c550_84e65287?usp=email
 :
PS2, Line 54:           if (rc.code != RC_OK) {
braces {} are not necessary for any arm of this statement



--
To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42743?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmo-asn1-tcap
Gerrit-Branch: master
Gerrit-Change-Id: I4a69167647dd0a8eb650b4c7cc47fd97928ebf5d
Gerrit-Change-Number: 42743
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Wed, 13 May 2026 16:04:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to