Attention is currently required from: fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41918?usp=email )
Change subject: ConfigurableParameter: do not magically overwrite the 'name' attribute ...................................................................... Patch Set 6: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/pysim/+/41918/comment/fddc3b06_a58ea1e1?usp=email : PS2, Line 7: Co > I apologized out-of-band for the emotional outburst, let me repeat this here: > sorry for the rant. […] so can we get a summary of the rationale in the commit log then? Historical remark on why it was writtne how it is before this patch: I personally enjoy automati/automagic things very much and prefer to reduce code size/boilerplate in favour of auto-generation whenever possible. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169 Gerrit-Change-Number: 41918 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 08 May 2026 08:32:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
