Attention is currently required from: laforge, neels.

fixeria has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/41918?usp=email )

Change subject: ConfigurableParameter: do not magically overwrite the 'name' 
attribute
......................................................................


Patch Set 4:

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/pysim/+/41918/comment/9d9a349a_bf7dde2b?usp=email :
PS2, Line 7: Co
> do we have a rationale for that? it was one of the neat features to not force 
> everyone to manually s […]
Neels: please explain this change. The commit message does not tell why 
magically overwriting the name is wrong, and I have no idea either...



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/41918?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I6f631444c6addeb7ccc5f6c55b9be3dc83409169
Gerrit-Change-Number: 41918
Gerrit-PatchSet: 4
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Fri, 24 Apr 2026 21:00:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to