Attention is currently required from: Hoernchen, laforge. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email )
Change subject: convolve: avoid function pointer casts by adding wrapper functions ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > I'm not an expert in this part of the code but .... […] Changing `_base_convolve_complex` to return void would indeed be simpler in isolation. However, it is used by `base_convolve_complex()`, which in turn is called from `convolve()` in sigProcLib.c. So changing its return type would propagate further up the call chain and potentially affect other code. To avoid a broader impact, I preferred to keep the existing return type and align the declarations instead. The only alternative (without introducing wrapper functions) would be to also make all `sse_conv_cmplx_*` and `sse_conv_real_*` functions return `len`, or to refactor all call sites of `_base_convolve_complex` / `_base_convolve_real` to stop relying on the return value and use `len` directly instead. If you have a preferred approach here, I’m happy to rework it accordingly. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75 Gerrit-Change-Number: 42655 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 14:43:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
