Attention is currently required from: Hoernchen, Timur Davydov. laforge has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email )
Change subject: convolve: avoid function pointer casts by adding wrapper functions ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: I'm not an expert in this part of the code but .... wouldn't it make more sense to either change the implementations of those functions to "return void" or to chnage the function pointer declarations to "return int"? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42655?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idecb118be285eb3e4691d1761d0d8fa24fd80c75 Gerrit-Change-Number: 42655 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Hoernchen <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Wed, 06 May 2026 07:52:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
