Attention is currently required from: dexter, laforge, neels. fixeria has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email )
Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 10: (2 comments) File pySim/esim/saip/batch.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/09bb5feb_871482a8?usp=email : PS10, Line 68: None I've changed this because several instances of this class may end up modifying the same dict instance, resulting in weird consequences. Typical Python pitfall. File pySim/esim/saip/param_source.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/e77eab95_070c7a83?usp=email : PS10, Line 205: val is None Changed to `... is None` to avoid raising exceptions for values like `0` and `False`. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 10 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: dexter <[email protected]> Gerrit-Comment-Date: Fri, 24 Apr 2026 15:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
