Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/pysim/+/42552?usp=email )
Change subject: filesystem: edit_{binary,record}_decoded: add encode/decode
examples
......................................................................
Patch Set 5:
(2 comments)
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/42552/comment/0ed8bc06_4d45922a?usp=email :
PS4, Line 575: return '\n'.join(line for line in text.splitlines() if
not line.lstrip().startswith('//'))
> I wonder if this could be improved. […]
Added a TODO.
https://gerrit.osmocom.org/c/pysim/+/42552/comment/f27075a9_1aa09a1a?usp=email :
PS4, Line 604: with open(filename, 'w') as text_file:
> Just an idea: What about adding a line like "//EF. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42552?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5a046a9c7ba7e08a98cf643d5a26bc669539b38f
Gerrit-Change-Number: 42552
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 07 Apr 2026 15:13:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <[email protected]>
