Attention is currently required from: fixeria.
dexter has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/pysim/+/42552?usp=email )
Change subject: filesystem: edit_{binary,record}_decoded: add encode/decode
examples
......................................................................
Patch Set 4: Code-Review+1 Verified+1
(3 comments)
Patchset:
PS4:
I have tested this with a few files and it works fine. To me this looks good.
File pySim/filesystem.py:
https://gerrit.osmocom.org/c/pysim/+/42552/comment/5912d3b5_2a52bb0b?usp=email :
PS4, Line 575: return '\n'.join(line for line in text.splitlines() if
not line.lstrip().startswith('//'))
I wonder if this could be improved. At the moment those comments seem only to
work when the line is started with a comment. When I use a comment after a JSON
statement, it is not ignored.
The current usecase does not require this. Also the logic becomes more
difficult because we still do not want filter something like "hello //world" in
an ascii string field. But maybe add a TODO so that we immediately see what is
messing, should we ever need to extend this.
https://gerrit.osmocom.org/c/pysim/+/42552/comment/52a06578_02e67d55?usp=email :
PS4, Line 604: with open(filename, 'w') as text_file:
Just an idea: What about adding a line like "//EF.UMPC (2F08) — UICC Maximum
Power Consumption" at the beginning?
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42552?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5a046a9c7ba7e08a98cf643d5a26bc669539b38f
Gerrit-Change-Number: 42552
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 07 Apr 2026 14:19:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
