Attention is currently required from: dexter.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/pysim/+/42553?usp=email )

Change subject: filesystem: JsonEditor: use NamedTemporaryFile
......................................................................


Patch Set 4:

(2 comments)

Patchset:

PS4:
> I have tested this. […]
This is intentional, see the next patch.


File pySim/filesystem.py:

https://gerrit.osmocom.org/c/pysim/+/42553/comment/9aa9b605_a492f280?usp=email :
PS4, Line 606:         self._file = tempfile.NamedTemporaryFile(prefix='pysim', 
suffix='.json',
> maybe continue to use 'pysim_' as prefix? […]
`NamedTemporaryFile` automatically adds `_` between prefix and the random file 
name.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42553?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If3b0bd0fcc90732407dbd03b9cc883f7abeb948e
Gerrit-Change-Number: 42553
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Tue, 07 Apr 2026 14:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <[email protected]>

Reply via email to