Attention is currently required from: fixeria. dexter has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42553?usp=email )
Change subject: filesystem: JsonEditor: use NamedTemporaryFile ...................................................................... Patch Set 4: (2 comments) Patchset: PS4: I have tested this. I think it is very helpful that the editor now knows that it is a JSON file and therefore switches on syntax highlighting. It all works will. However when I intentionally provoke a JSONDecodeError I can see that the file continues to exist. With the current master the temp directory vanishes. Probably there is something broken now. I think it would be good if you could check this back. File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/42553/comment/e6d71e82_c25046a8?usp=email : PS4, Line 606: self._file = tempfile.NamedTemporaryFile(prefix='pysim', suffix='.json', maybe continue to use 'pysim_' as prefix? (maybe it would also make sense to encode the FID path into the filename? I don't know maybe some will find this hepful) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If3b0bd0fcc90732407dbd03b9cc883f7abeb948e Gerrit-Change-Number: 42553 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2026 14:43:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
