Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email )
Change subject: assignment_fsm: check ipaccess channel mode support ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/assignment_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42590/comment/21992dcf_aa3dcec5?usp=email : PS1, Line 375: const struct ipacc_supp_feat *feat = > might be prudent to add an OSMO_ASSERT on the correct BTS type here. […] I can add an assert, but this is a static function that is currently used only once, and even if someone calls it for a non-ipaccess BTS nothing bad will happen: it will return `true` early because `!feat->present` will be `true` (because Supported Features IE was never received). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I680ba7993786f5486d671f931e75df4543670a37 Gerrit-Change-Number: 42590 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Tue, 07 Apr 2026 13:28:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]>
