Attention is currently required from: fixeria.

laforge has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email )

Change subject: assignment_fsm: check ipaccess channel mode support
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/osmo-bsc/assignment_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/42590/comment/ca751c11_8a3cac54?usp=email
 :
PS1, Line 375:  const struct ipacc_supp_feat *feat =
might be prudent to add an OSMO_ASSERT on the correct BTS type here. Just in 
case anyone ever should call it from a context where those feature bits are not 
set at all and hence would result in a rather silent failure



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42590?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I680ba7993786f5486d671f931e75df4543670a37
Gerrit-Change-Number: 42590
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Tue, 07 Apr 2026 11:02:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

Reply via email to