Attention is currently required from: dexter, fixeria. laforge has uploaded a new patch set (#5) to the change originally created by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42381?usp=email )
The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: sms: fix flags_construct in SMS_DELIVER ...................................................................... sms: fix flags_construct in SMS_DELIVER * field `tp_rp` appears at bit positions 7 and 5 ** bit 7 should be `tp_rp` (Reply Path) ** bit 5 should be `tp_sri` (Status Report Indication) * field `tp_lp` is completely missing ** should be at bit position 3 Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8 --- M pySim/sms.py 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/42381/5 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: dexter <[email protected]>
