fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/42381?usp=email )
Change subject: sms: fix flags_construct in SMS_DELIVER
......................................................................
sms: fix flags_construct in SMS_DELIVER
* field `tp_rp` appears at bit positions 7 and 5
** bit 7 should be `tp_rp` (Reply Path)
** bit 5 should be `tp_sri` (Status Report Indication)
* field `tp_lp` is completely missing
** should be at bit position 3
Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8
---
M pySim/sms.py
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/81/42381/1
diff --git a/pySim/sms.py b/pySim/sms.py
index aefc874..62601b0 100644
--- a/pySim/sms.py
+++ b/pySim/sms.py
@@ -169,8 +169,14 @@
class SMS_DELIVER(SMS_TPDU):
"""Representation of a SMS-DELIVER T-PDU. This is the Network to MS/UE
(downlink) direction."""
- flags_construct = BitStruct('tp_rp'/Flag, 'tp_udhi'/Flag, 'tp_rp'/Flag,
'tp_sri'/Flag,
- Padding(1), 'tp_mms'/Flag,
'tp_mti'/BitsInteger(2))
+ flags_construct = BitStruct('tp_rp'/Flag,
+ 'tp_udhi'/Flag,
+ 'tp_sri'/Flag,
+ Padding(1),
+ 'tp_lp'/Flag,
+ 'tp_mms'/Flag,
+ 'tp_mti'/BitsInteger(2))
+
def __init__(self, **kwargs):
kwargs['tp_mti'] = 0
super().__init__(**kwargs)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/42381?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8
Gerrit-Change-Number: 42381
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
