Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email )
Change subject: enb_{proxy,registry}: signal MME conn info on SCTP comm_up
......................................................................
Patch Set 2:
(1 comment)
File src/enb_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445/comment/55899490_492593e1?usp=email
:
PS2, Line 260: enb_registry:notify_mme_comm_up(S#state.enb_handle,
conn_info(NewS)),
> I'd say it makes more sense to register the mme *before* generating external
> events (send msg) which […]
MMEs are already registered at this point - the `mme_registry` takes care of
that. Here we're signalling **connection** information to a selected MME, i.e.
SCTP assoc ID, local address and port (plus some extra info that is separated
from `mme_conn_info()` in a follow-up patch).
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea9ba4fdf961e6cd262edc154884a2eee3d95355
Gerrit-Change-Number: 42445
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 20 Mar 2026 09:38:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
