Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email )
Change subject: enb_{proxy,registry}: signal MME conn info on SCTP comm_up
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/enb_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445/comment/817183af_d0ef715e?usp=email
:
PS2, Line 260: enb_registry:notify_mme_comm_up(S#state.enb_handle,
conn_info(NewS)),
I'd say it makes more sense to register the mme *before* generating external
events (send msg) which may want to interact with the information.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42445?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Iea9ba4fdf961e6cd262edc154884a2eee3d95355
Gerrit-Change-Number: 42445
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Fri, 20 Mar 2026 08:45:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
