Attention is currently required from: pespin.

Timur Davydov has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )

Change subject: transceiver: split control command handling from socket I/O
......................................................................


Patch Set 8:

(1 comment)

File Transceiver52M/Transceiver.cpp:

https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/687766e3_5b0a1d92?usp=email
 :
PS7, Line 1090:     return rc;
> Ok I think I'm starting to understand the problem here: […]
Thanks for the explanation, that makes sense.

I've updated the implementation to use two states: a success flag (whether a 
response should be sent) and a retcode (whether a failure occurred that should 
propagate to the caller).



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e
Gerrit-Change-Number: 42410
Gerrit-PatchSet: 8
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 18 Mar 2026 15:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to