Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email )
Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 7: (1 comment) File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/4c991da9_eb4a9244?usp=email : PS7, Line 1090: return rc; Ok I think I'm starting to understand the problem here: In your logic, returning error means "don't send a response", but that's actually decoupled. See how caller of ctrl_sock_handle_rx() uses the rc<0 to trigger stop of osmo-trx program. The idea of returning 0 in the SETSLOT failure was to simply tell the other peer that the cmd failed, but it kept osmo-trx alive. It is ofc a bug that no answer was being sent in that case. So your ctrl_cmd_handle() function should actually return 2 independent type of information, as per the above: * Whether a response needs to be transmitted * Whether a failure occurred which should trigger osmo-trx process stop. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 7 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Wed, 18 Mar 2026 14:45:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
