Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email )
Change subject: doc/manuals: document the metrics ...................................................................... Patch Set 5: (3 comments) File doc/manuals/chapters/metrics.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/290def47_e20298fc?usp=email : PS4, Line 5: https://github.com/Feuerlabs/exometer_core[exometer_core] library. Two > "OsmoS1GW exposes internal metrics using the […] I believe it's important to mention it here, so I've removed the library reference in `configuration.adoc`. I've also mentioned the StatsD reporter plugin here. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/d7c22b20_0ebf65e0?usp=email : PS4, Line 25: > is this explanation of how the stats are stored internally useful to the user? Right, this is more relevant for developers. I've reworked this section explaining the hierarchical nature of the metric names. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/5685d006_8f130d54?usp=email : PS4, Line 68: | `s1ap.proxy.in_pkt.erab_setup_req` | E-RAB SETUP REQUEST PDUs > How about: […] Done -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iacfefd387d0cd26eebbbeba0cd37efa78f90bb46 Gerrit-Change-Number: 42365 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 15:51:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <[email protected]>
