Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email )
Change subject: doc/manuals: document the metrics ...................................................................... Patch Set 4: (3 comments) File doc/manuals/chapters/metrics.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/542970d8_68bed676?usp=email : PS4, Line 5: https://github.com/Feuerlabs/exometer_core[exometer_core] library. Two "OsmoS1GW exposes internal metrics using the https://github.com/Feuerlabs/exometer_core[exometer_core] library." this seems unnecessary, given that it is mentioned in e.g. the configuration section already. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/0345ea47_97504f60?usp=email : PS4, Line 25: is this explanation of how the stats are stored internally useful to the user? https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/7f319630_1d750336?usp=email : PS4, Line 68: | `s1ap.proxy.in_pkt.erab_setup_req` | E-RAB SETUP REQUEST PDUs How about: ```suggestion | `s1ap.proxy.in_pkt.erab_setup_req` | Received E-RAB SETUP REQUEST PDUs ``` Same for all below with in_pkt. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iacfefd387d0cd26eebbbeba0cd37efa78f90bb46 Gerrit-Change-Number: 42365 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:16:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
