Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: device/websdr: add WebSDR transceiver backend and build target ...................................................................... Patch Set 3: (2 comments) File Transceiver52M/device/websdr/TransceiverWebSdr.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3d1c750c_4ab71044?usp=email : PS3, Line 50: : Transceiver(cfg, wTransmitLatency, wRadioInterface) I'm not really liking the patch. You are mixing tons of stuff in the same patch and changing/maningling the whole architecture of the file structure. device backends under Transcevier52/device/ are expected to have mostly only implementations/subclasses of radioDevice, not whole reimplementations of Transceiver, etc. Something is wrong here. File Transceiver52M/device/websdr/osmo-trx-websdr.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/0cd47618_c1a5e847?usp=email : PS3, Line 151: g_trx_ctx->cfg.filler = FILLER_DUMMY; check indentation here and below. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d Gerrit-Change-Number: 42411 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Attention: Timur Davydov <[email protected]> Gerrit-Comment-Date: Mon, 16 Mar 2026 10:15:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
