Jenkins Builder has posted comments on this change by Timur Davydov. ( 
https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )

Change subject: device/websdr: add WebSDR transceiver backend and build target
......................................................................


Patch Set 1:

(7 comments)

File Transceiver52M/device/websdr/TransceiverWebSdr.h:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/86b87ddd_cba35547?usp=email
 :
PS1, Line 58:   int post_tx_burst(size_t chan, char* buffer, int msgLen);
"foo* bar" should be "foo *bar"


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/173060ea_5f6bbf7d?usp=email
 :
PS1, Line 70: #endif /* TRANSCEIVER_WEBSDR_H */
adding a line without newline at end of file


File Transceiver52M/device/websdr/osmo-trx-websdr.h:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/d11fd06b_d5bc9b1a?usp=email
 :
PS1, Line 31: int osmotrxlib_process_command(const char* buffer, char 
*response, size_t response_size);
"foo* bar" should be "foo *bar"


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/3753bf59_11d09060?usp=email
 :
PS1, Line 34: int osmotrxlib_push_rx_short_vector(short* buffers, int samples, 
int underrun,
"foo* bar" should be "foo *bar"


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/f0b219d8_62b21ed0?usp=email
 :
PS1, Line 36: int osmotrxlib_get_rx_burst(char* buf, int maxLen);
"foo* bar" should be "foo *bar"


Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b5b3c413_aa87627a?usp=email
 :
PS1, Line 40: int osmotrxlib_put_tx_burst(char* buffer, int msgLen);
"foo* bar" should be "foo *bar"


File Transceiver52M/device/websdr/radioInterfaceWebSdr.h:

Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/4d152116_94e19ef3?usp=email
 :
PS1, Line 27:   int fillPullBuffer(short** buffers, int samples,
"foo** bar" should be "foo **bar"



--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ia0d340c323c2eea28fbe82601ba0af7cfbd68f6d
Gerrit-Change-Number: 42411
Gerrit-PatchSet: 1
Gerrit-Owner: Timur Davydov <[email protected]>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Mon, 16 Mar 2026 09:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to