Attention is currently required from: neels. dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40200?usp=email )
Change subject: personalization: indicate default ParamSource per ConfigurableParameter ...................................................................... Patch Set 9: Code-Review+1 (2 comments) Patchset: PS9: I think this patch looks ok. I would recommend to double check the code paths so that we can be sure that the luhn checksum of the ICCID is always correct. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40200/comment/96a9a801_96a414a3?usp=email : PS9, Line 362: default_source = param_source.IncDigitSource The ICCID has a luhn checksum at the end. A wrong checksum may cause the eUICC to just refuse the profile installation. As far as I know, the IncDigitSource just increments, it does not add a checksum or anything. As far as I can see you are using enc_iccid to encode the value in apply_val. This function only does the nibble swap. sanitize_iccid would calculate the luhn if it is not yet present, but its only called in validate_val... Maybe you calculate the luhn somewehere and everything is fine. I am just writing this to make sure you are aware of this. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40200?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie58d13bce3fa1aa2547cf3cee918c2f5b30a8b32 Gerrit-Change-Number: 40200 Gerrit-PatchSet: 9 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Fri, 06 Mar 2026 12:32:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
