Attention is currently required from: neels.

dexter has posted comments on this change by neels. ( 
https://gerrit.osmocom.org/c/pysim/+/40199?usp=email )

Change subject: personalization: allow reading back multiple values from PES
......................................................................


Patch Set 10:

(2 comments)

Patchset:

PS10:
As far as I understand, this patch only extends the patch from before so that 
we can read back multiple values. (I also see that this patch fixes some 
unrelated things from the patch before) Maybe it makes sense to squash both 
patches into one?


File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/40199/comment/2be3fe1e_9d30e01f?usp=email :
PS10, Line 209:     def get_values_from_pes(cls, pes: ProfileElementSequence) 
-> Generator:
Ah, ok here you fix the comment chars. Should be ok then.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2
Gerrit-Change-Number: 40199
Gerrit-PatchSet: 10
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: dexter <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Comment-Date: Fri, 06 Mar 2026 12:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to