Attention is currently required from: fixeria, laforge, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email )

Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function
......................................................................


Patch Set 10:

(3 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/4763f381_bdad425e?usp=email
 :
PS10, Line 7: rework TC_sgsn_context_req_out to actual function
> I find the commit name confusing. […]
That is works.


File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/75982b93_9d4237ff?usp=email
 :
PS10, Line 3237: tr_SGSNContextReqPDU
> Weird formatting here.
Is it this way better?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/277ac15c_86c59e66?usp=email
 :
PS10, Line 3350: f_sleep(1.0);
> Since I am already the second person asking why do you add an artificial 
> delay here, please add a co […]
Removed it.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3
Gerrit-Change-Number: 39017
Gerrit-PatchSet: 10
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: fixeria <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 26 Sep 2025 09:53:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>

Reply via email to