Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email )
Change subject: SGSN_Tests: rework TC_sgsn_context_req_out to actual function ...................................................................... Patch Set 10: (3 comments) This change is ready for review. File sgsn/SGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/a474578f_d60dbf1a?usp=email : PS3, Line 3187: // add_rai_oct := rai_to_oct(add_rai); > why is this commented out? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/8a9efa60_f3b55c4e?usp=email : PS3, Line 3200: // [] GTP[GTP_GGSN_IDX].receive(tr_GTPC_SGSNContextReq(g_gn_iface_peer, tr_SGSNContextReqPDU(rai := rai, ptmsi := ts_PTMSI(ptmsi), ptmsi_sig := ts_PTMSI_sig(ptmsi_sig), rat_type := int2oct(enum2int(rat_type), 1)))) -> value gtpc_pdu { > why is this commented out? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017/comment/f4c3c90c_b6d806aa?usp=email : PS3, Line 3311: f_sleep(1.0); > is this really needed? yes, I ran into timeouts otherwise when tearing it down. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39017?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0666a518aed57c2594653ab6b0f801c4193fd2f3 Gerrit-Change-Number: 39017 Gerrit-PatchSet: 10 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 25 Aug 2025 17:05:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]>
