Attention is currently required from: fixeria. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email )
Change subject: FR/HR/EFR: centralize TCH UL SID classification ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/41048/comment/f4506f26_b85231c0?usp=email : PS2, Line 2358: /* This static function should never be called except for : * V1 and EFR speech modes. */ : > I suggest to return here, like you do above: […] If we were to call `tch_ul_fr_hr_efr()` from `l1sap_tch_ind()` unconditionally like you suggest, the code at the top of `tch_ul_fr_hr_efr()` before the per-codec switch will execute for all channel modes, including those that aren't FR/HR/EFR. While no actual harm will result, it still feels philosophically wrong. Therefore, I prefer to keep the current arrangement. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41048?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id6c8c146962de2f173760889eb232693bb4229d3 Gerrit-Change-Number: 41048 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Fri, 05 Sep 2025 22:09:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]>
