Attention is currently required from: pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( 
https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email )

Change subject: Re-introduce Iu/UTRAN support
......................................................................


Patch Set 6:

(1 comment)

File src/sgsn/gprs_routing_area.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/40813/comment/8068ecb9_ad548eb8?usp=email
 :
PS6, Line 487:  else if (mmctx->p_tmsi_old != GSM_RESERVED_TMSI)
> this else can be removed, you forgot.
I think it is better this way,
because it explicit connects both statements and keep then in an order.
IMHO it improve the code readiness.



--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40813?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I1b1aedd2a7c358bd388aa3d8a9f3c6a0011b4889
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 21 Aug 2025 21:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to